Remove --host-whitelist 2.0 #7884
Conversation
Signed-off-by: Marlene Marz <[email protected]>
Signed-off-by: Marlene Marz <[email protected]>
| paramLabel = "<hostname>[,<hostname>...]... or * or all", | ||
| description = | ||
| "Deprecated in favor of --host-allowlist. Comma separated list of hostnames to allow for RPC access, or * to accept any host (default: ${DEFAULT-VALUE})") | ||
| private final JsonRPCAllowlistHostsProperty hostsWhitelist = new JsonRPCAllowlistHostsProperty(); |
There was a problem hiding this comment.
There is also some code in the configure method of BesuCommand that uses the hostsWhitelist variable that needs to be removed as well
There was a problem hiding this comment.
Thanks for the review! You mean this part further down in the same file, of another one?
// hostsWhitelist is a hidden option. If it is specified, add the list to hostAllowlist
if (!hostsWhitelist.isEmpty()) {
// if allowlist == default values, remove the default values
if (hostsAllowlist.size() == 2
&& hostsAllowlist.containsAll(List.of("localhost", "127.0.0.1"))) {
hostsAllowlist.removeAll(List.of("localhost", "127.0.0.1"));
}
hostsAllowlist.addAll(hostsWhitelist);
}
There was a problem hiding this comment.
@JanetMo if you run ./gradlew compileJava you will see compile errors locally
There was a problem hiding this comment.
@macfarla Thanks, unfortunately we were still not able to run the repo locally... Could you guide us on which piece of code to remove?
There was a problem hiding this comment.
@macfarla Thanks, appreciate the support. I retried but still wasn't able to build it locally, is there a way to unassign from the issue? I think I'm not up for it, and probably holding you back on with this one.
There was a problem hiding this comment.
ok yes I can unassign you @JanetMo - you're welcome back any time - but being able to compile the code is a must :)
There was a problem hiding this comment.
@macfarla Thanks, I'm sorry it didn't work despite your help, learned something about Besu nevertheless 👍
| @@ -66,7 +66,6 @@ services: | |||
| - --rpc-ws-enabled | |||
| - --rpc-ws-apis=admin,eth,miner,web3,net,priv,eea | |||
| - --rpc-ws-host=0.0.0.0 | |||
| - --host-whitelist=* | |||
There was a problem hiding this comment.
instead of deleting this line, can you change to host-allowlist
There was a problem hiding this comment.
Alright, I changed it to host-allowlist
| @@ -84,7 +83,6 @@ services: | |||
| - --rpc-ws-enabled | |||
| - --rpc-ws-apis=admin,eth,miner,web3,net,priv,eea | |||
| - --rpc-ws-host=0.0.0.0 | |||
| - --host-whitelist=* | |||
There was a problem hiding this comment.
instead of deleting this line, can you change to host-allowlist
There was a problem hiding this comment.
Changed as well, thanks for reviewing!
Signed-off-by: Marlene Marz <[email protected]>
remove the --host-whitelist option, issue #7761
deleted the command and it's associated tests, the changelog was already adapted